Use GraphQL version of Relate-API when available (in Neo4j Desktop) #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
force-pushed
the
relate-api-take-2
branch
from
78a54c5 to
49a2b27
Compare
oskarhane
force-pushed
the
relate-api-take-2
branch
from
49a2b27 to
1d4ad58
Compare
oskarhane
force-pushed
the
relate-api-take-2
branch
from
d08fa31 to
486a31c
Compare
oskarhane
force-pushed
the
relate-api-take-2
branch
from
dac90bc to
5f9d978
Compare
|
You reviewed the original PR (linked in description) for this @huboneo, could I ask you to have a look at this new one as well? |
huboneo
approved these changes
Jan 13, 2020
src/browser/modules/DBMSInfo/__snapshots__/MetaItems.test.js.snap
Outdated
Show resolved
Hide resolved
oskarhane
force-pushed
the
relate-api-take-2
branch
from
0bc8d61 to
4644152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of the reverted #969
Neo4j Browser should behave just as before, but using the GraphQL version rather than the injected version of the relate-api.
We're using the Apollo lib as our client.
The GraphQL queries are loaded on build so we don't need to process AST's on the client side, see https://www.apollographql.com/docs/react/recipes/webpack/.
Adapt to color theme preferences set in macOS (not working yet, might not be implemented in Neo4j Desktop, need to check)(not implemented on desktop side)Note: We're still using one function from the injected API and that's
neo4jDesktopApi.getKerberosTicketsince it's not ported to the GraphQL API yet.Should not be merged until Neo4j Desktop implements the relate-api correctly.