Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestKit backend: except txMeta as Cypher types #662

Merged
merged 4 commits into from
Dec 16, 2022
Merged

TestKit backend: except txMeta as Cypher types #662

merged 4 commits into from
Dec 16, 2022

Conversation

robsdedude
Copy link
Member

RichardIrons-neo4j
RichardIrons-neo4j reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing except a typo, but also I think run a formatter on it to apply the .editorconfig settings.

Neo4j.Driver/Neo4j.Driver.Tests.TestBackend/Protocol/Session/SessionRun.cs Outdated Show resolved Hide resolved
RichardIrons-neo4j
RichardIrons-neo4j approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@robsdedude
Copy link
Member Author

The same 5 tests as on 5.0 are failing.

@robsdedude robsdedude merged commit 6906193 into neo4j:5.0 Dec 16, 2022
@robsdedude robsdedude deleted the testkit-backend-tx-meta-cypher-type branch December 16, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardIrons-neo4j RichardIrons-neo4j RichardIrons-neo4j approved these changes

@thelonelyvulpes thelonelyvulpes Awaiting requested review from thelonelyvulpes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @RichardIrons-neo4j