Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mapping api out of preview namespace #784

Merged

Conversation

RichardIrons-neo4j
Copy link
Contributor

Move all the mapping classes out of the preview namespace and into Neo4j.Driver.Mapping.

@RichardIrons-neo4j RichardIrons-neo4j marked this pull request as ready for review May 1, 2024 16:03
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to add a few docs for release

@@ -15,7 +15,7 @@

using System;

namespace Neo4j.Driver.Preview.Mapping;
namespace Neo4j.Driver.Mapping;

public class MappingFailedException : Neo4jException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing docs on this public class

@@ -16,7 +16,7 @@
using System;
using System.Linq.Expressions;

namespace Neo4j.Driver.Preview.Mapping;
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neo4j.Driver.Mapping.IMappingBuilder.Map is missing documentation for optional parameter

Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The find replace appears to have functioned as advertised.

@RichardIrons-neo4j RichardIrons-neo4j merged commit 6db2d7f into neo4j:5.0 May 2, 2024
5 checks passed
@darcome
Copy link

darcome commented May 3, 2024

Hello, where can I find docs about mapping? Thanks in advance!

@RichardIrons-neo4j
Copy link
Contributor Author

RichardIrons-neo4j commented May 3, 2024

@darcome Here is a link to the API documentation for mapping, which is correct and up to date. We do not have full documentation for the mapping functionality yet, however you can look through some of the pull requests which contain some information. Note that this documentation is now out of date in some regards.

First addition of mapping: #729

Addition of constructor mapping: #751

And then these changes made for 5.20 are that the mapping is now case sensitive in matching C# symbols to database fields and properties, and that mapping will fail if a property is not found in the record. I hope this information gets you started; feel free to start a discussion if you need help with it.

@darcome
Copy link

darcome commented May 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants