Allow tx timeout to be 0 or null. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust TestKit back end to accept * `null` timeout: send `null` to server (or omit as it's the default) * and integer: configure as timeout in milliseconds * omitted timeout: don't explicitly configure the timeout (user driver default)
robsdedude
force-pushed
the
tx-timeout
branch
from
49b203f to
73e525b
Compare
injectives
reviewed
Jan 13, 2022
injectives
reviewed
Jan 13, 2022
injectives
reviewed
Jan 13, 2022
injectives
reviewed
Jan 13, 2022
...ckend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionBeginTransaction.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jan 13, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionRun.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jan 13, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/CustomDriverError.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jan 13, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/CustomDriverError.java
Show resolved
Hide resolved
injectives
reviewed
Jan 13, 2022
...ckend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionBeginTransaction.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jan 13, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionRun.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitriy Tverdiakov <dmitriy.tverdiakov@neo4j.com>
injectives
reviewed
Jan 14, 2022
driver/src/test/java/org/neo4j/driver/TransactionConfigTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitriy Tverdiakov <dmitriy.tverdiakov@neo4j.com>
injectives
reviewed
Jan 18, 2022
injectives
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust TestKit back end to accept
nulltimeout: sendnullto server (or omit as it's the default)