Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude US/Pacific-New from randomized timezones #1120

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Exclude US/Pacific-New from randomized timezones #1120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a70fba8
Exclude US/Pacific-New from randomized timezones. (#1105)
michael-simons Dec 20, 2021
f917d52
Update driver/src/test/java/org/neo4j/driver/util/TemporalUtil.java
injectives Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions driver/src/test/java/org/neo4j/driver/util/TemporalUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ public final class TemporalUtil
* For example "Canada/East-Saskatchewan" will be returned as "Canada/Saskatchewan".
* Other time zones are not working correctly in some Java versions
*/
private static final List<String> BLACKLISTED_ZONE_IDS = Arrays.asList(
private static final List<String> EXCLUDED_ZONE_IDS = Arrays.asList(
"Canada/East-Saskatchewan",
"Chile/EasterIsland",
"Africa/Casablanca",
"tzid",
"Asia/Qostanay",
"America/Santiago",// Can cause flakyness on windows, see https://stackoverflow.com/questions/37533796/java-calendar-returns-wrong-hour-in-ms-windows-for-america-santiago-zone.
"US/Pacific-New", // Appeared out of nothing in windows, does not test reliable "org.neo4j.driver.exceptions.ClientException: Unable to construct ZonedDateTime value: `Unknown time-zone ID: US/Pacific-New`"
injectives marked this conversation as resolved.
Show resolved Hide resolved
"Pacific/Easter"
);

Expand Down Expand Up @@ -128,7 +129,7 @@ private static ZoneId randomZoneId()
{
Set<String> availableZoneIds = ZoneId.getAvailableZoneIds()
.stream()
.filter( id -> !BLACKLISTED_ZONE_IDS.contains( id ) )
.filter( id -> !EXCLUDED_ZONE_IDS.contains( id ) )
.collect( toSet() );

int randomIndex = random().nextInt( availableZoneIds.size() );
Expand Down