Add substitutions for DriverFactory#getOrCreateMetricsProvider. #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an eager class loading of Micrometer when compiling on GraalVM native image and fixes neo4j#1182.
|
Reproducer which I used for testing https://github.com/michael-simons/neo4j-java-driver-native-example Allows now turning on metrics. With latest snapshot (build) locally it works. Substitutions will turn of metrics now when there's no micrometer. |
meistermeier
approved these changes
Mar 14, 2022
|
Reproducer shows the problem with |
injectives
approved these changes
Mar 14, 2022
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Mar 16, 2022
…j#1183) This prevents an eager class loading of Micrometer when compiling on GraalVM native image and fixes neo4j#1182.
injectives
added a commit
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an eager class loading of Micrometer when compiling on GraalVM native image and fixes #1182.