Migrate RoutingExamplesIT to Testcontainers #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hmm… This isn't doing a real cluster connection anymore. Is that on purpose?
If so, ignore my feedback and move on.
If not, we have a JUNit extension that actually brings up a cluster: https://github.com/michael-simons/junit-jupiter-causal-cluster-testcontainer-extension
|
It is a single node cluster. This should be sufficient for these tests and will make build a bit lighter. |
|
I have seen the exciting extension that we might use when we need a multinode cluster. 👍 |
injectives
force-pushed
the
feature/example
branch
2 times, most recently
from
9dfe34a to
0f79ba2
Compare
injectives
force-pushed
the
feature/example
branch
from
0f79ba2 to
e846007
Compare
michael-simons
approved these changes
May 10, 2022
gjmwoods
reviewed
May 10, 2022
driver/src/test/java/org/neo4j/driver/stress/CausalClusteringStressIT.java
Show resolved
Hide resolved
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Nov 22, 2022
injectives
added a commit
that referenced
this pull request
Nov 23, 2022
* Migrate RoutingExamplesIT to Testcontainers (#1215) * Migrate java-driver-rx-tck (#1224) * Migrate java-driver-rx-tck This update migrates verification tests from `java-driver-rx-tck` to this project. * Update surefire and failsafe to 3.0.0-M6 * Migrate tests depending on Boltkit to use Docker (#1256) Boltkit has been deprecated and requires additional setup on the host to run tests. This update migrates tests depending on Boltkit to use Docker that is needed for Testkit testing as well. * Skip tests incompatible with 5.x server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.