Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete superflous subsitutions. #1312

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

michael-simons
Copy link
Contributor

As GraalVM native image switched the default to initialize mostly everything to runtime initialization by default (apart from known safe classes https://www.graalvm.org/22.1/reference-manual/native-image/ClassInitialization/#automatic-initialization-of-safe-classes), we don’t have to cater for the default in the driver. The rest is taking care of by the recent netty versions.

In Quarkus we must defer Netty SSL explicitly to runtime (return new RuntimeInitializedPackageBuildItem("io.netty.handler.ssl“)), as Quarkus insists of Built-Time-Initialization by default and our SSL config will than trigger the above at a point in time in which the Quarkus built-in substitions are not in place yet.

As GraalVM native image switched the default to initialize mostly everything to runtime initialization by default (apart from known safe classes https://www.graalvm.org/22.1/reference-manual/native-image/ClassInitialization/#automatic-initialization-of-safe-classes), we don’t have to cater for the default in the driver. The rest is taking care of by the recent netty versions.

In Quarkus we must defer Netty SSL explicitly to runtime (`return new RuntimeInitializedPackageBuildItem("io.netty.handler.ssl“)`), as Quarkus insists of Built-Time-Initialization by default and our SSL config will than trigger the above at a point in time in which the Quarkus built-in substitions are not in place yet.
@michael-simons
Copy link
Contributor Author

Please update TC to use ghcr.io/graalvm/native-image:ol8-java17-22.2.0 for the verification.

@injectives injectives merged commit 9c8f689 into 5.0 Sep 22, 2022
@injectives injectives deleted the issue/graalvm-substitutions-clashing-in-quarkus branch September 22, 2022 11:58
injectives pushed a commit to injectives/neo4j-java-driver that referenced this pull request Jun 28, 2023
* Delete superflous subsitutions.

As GraalVM native image switched the default to initialize mostly everything to runtime initialization by default (apart from known safe classes https://www.graalvm.org/22.1/reference-manual/native-image/ClassInitialization/#automatic-initialization-of-safe-classes), we don’t have to cater for the default in the driver. The rest is taking care of by the recent netty versions.

In Quarkus we must defer Netty SSL explicitly to runtime (`return new RuntimeInitializedPackageBuildItem("io.netty.handler.ssl“)`), as Quarkus insists of Built-Time-Initialization by default and our SSL config will than trigger the above at a point in time in which the Quarkus built-in substitions are not in place yet.

* Remove all runtime initializations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants