Add 2 access options to Config and refactor DriverFactory #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/factory
branch
from
20acfef to
5b645b3
Compare
This update adds 2 getters for existing configuration options in `Config`: - `routingTablePurgeDelayMillis()` - provides access to value configured via `ConfigBuilder.withRoutingTablePurgeDelay(long, TimeUnit)` - `maxTransactionRetryTimeMillis()` - provides access to value configured via `ConfigBuilder.withMaxTransactionRetryTime(long, TimeUnit)` It also includes internal `DriverFactory` refactoring.
injectives
force-pushed
the
feature/factory
branch
from
3d15b4e to
1e5eae7
Compare
injectives
changed the title
injectives
requested review from
gjmwoods,
tobias-johansson and
AndyHeap-NeoTech
and removed request for
gjmwoods
| SecuritySettings securitySettings = config.securitySettings(); | ||
| SecurityPlan securityPlan = securitySettings.createSecurityPlan(uri.getScheme()); | ||
| return driverFactory.newInstance(uri, authToken, routingSettings, retrySettings, config, securityPlan); | ||
| return driverFactory.newInstance(uri, authToken, config); |
tobias-johansson
approved these changes
Dec 20, 2022
AndyHeap-NeoTech
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds 2 getters for existing configuration options in
Config:routingTablePurgeDelayMillis()- provides access to value configured viaConfigBuilder.withRoutingTablePurgeDelay(long, TimeUnit)maxTransactionRetryTimeMillis()- provides access to value configured viaConfigBuilder.withMaxTransactionRetryTime(long, TimeUnit)It also includes internal
DriverFactoryrefactoring.