Updated session acquisition #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan of automatically handle retries on read sessions didn't really pan out since we don't really control when data is transported over the network and errors are noticed. Instead we treat reads and writes in the same way, i.e. throwing a `SessionExpiredException` on all connection failures.
pontusmelke
force-pushed
the
1.1-acquisition
branch
from
e1bec19 to
e30e01e
Compare
The connection pool is no longer responsible for maintaining the servers since we must treat READ and WRITE servers differently. Instead added a separate containers for the different server types.
Instead of two separate procedure calls, one to do routing and one to do acquisition we merge them into one call containing the same information.
pontusmelke
changed the title
pontusmelke
force-pushed
the
1.1-acquisition
branch
4 times, most recently
from
c67f8ba to
b9212df
Compare
pontusmelke
force-pushed
the
1.1-acquisition
branch
from
b9212df to
f9f7b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getServersto establish view of cluster