Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to driver #244

Merged
merged 4 commits into from
Oct 7, 2016
Merged

Fixes to driver #244

merged 4 commits into from
Oct 7, 2016

Conversation

pontusmelke
Copy link
Contributor

  • Don't fail if ACK_FAILURE is ignored
  • Don't put the same connection back in the pool multiple times
  • If connection is closed it is a ConnectionFailureException

@pontusmelke
Do not fail i ACK_FAIL is responded with IGNORE
d17b10a
@pontusmelke
Don't add the same connection multiple times
cdc79ca 
The same connections was being added to the queue if close was called more
than once. Eventually the queue will be full and we close the connection, but
since the queue now contains multiple identical copies we will also close these.
@pontusmelke pontusmelke added the bug label Oct 6, 2016
@pontusmelke pontusmelke force-pushed the 1.1-fixup branch 2 times, most recently from 614cf13 to f753d3b Compare October 6, 2016 16:01
@pontusmelke
Switch to ConnectionFailureException
5540e80
@pontusmelke
Make sure connection is only called once.
3004db0 
Instead of guarding in `PooledConnection` as well as in `NetworkSession` we
make sure we only close connection once in `RoutingDriver`
@zhenlineo zhenlineo merged commit 0cb7a9e into neo4j:1.1 Oct 7, 2016
@zhenlineo zhenlineo deleted the 1.1-fixup branch October 7, 2016 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pontusmelke @zhenlineo