Deprecate TOFU, add TRUST_ALL and remove E_NON_LOCAL #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2016
zhenlineo
reviewed
Nov 1, 2016
| // intentional fallthrough | ||
| // END OF DEPRECATED CASES // | ||
|
|
||
| case TRUST_ALL_CERTIFICATES: |
There was a problem hiding this comment.
Shall we default to TRUST_ALL for old TRUST_SIGNED? isn't it more reasonable to fall through to TRUST_CUSTOM_CA? The log.warn at line 233 suggests it would be TRUST_CUSTOM_CA
There was a problem hiding this comment.
Yes, you're completely right, I messed up the ordering there.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUST_ALL_CERTIFICATESand sets as default trust modeTRUST_ON_FIRST_USETRUST_ON_FIRST_USEin combination withbolt+routingENCRYPTION_NON_LOCAL