Fixed couple flaky tests and improved null handling #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that asserted blocking operations are prohibited in even loop threads were flaky. They assumed lambdas in `CompletionStage` chain are always executed by event loop threads. However, this is not true. There is no guarantee which thread executes the callback. This commit adds additional check to only perform blocking operation when in event loop thread. Exceptions are expected in this case.
Previously code failed with NPE when provided async transaction function returned null. This commit fixes the problem by wrapping null in a completed future.
lutovich
force-pushed
the
1.5-flaky-tests
branch
from
ff5861c to
992ef0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.