Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Async Testkit Backend support #987

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Aug 17, 2021

This update brings async Testkit backend support that uses async driver for testing and is compatible with the current Testkit protocol. This allows async driver testing using the same Testkit tests transparently.

Not all requests are implemented in this PR. For instance, the resolver implementation will be added separately. The current update enables a substantial amount of tests to be executed.

In addition, a separate PR is planned to migrate the sync backend to the new Netty based implementation.

@injectives injectives marked this pull request as draft August 17, 2021 16:46
@injectives injectives marked this pull request as ready for review August 18, 2021 12:01
This update brings async Testkit backend support that uses async driver for testing and is compatible with the current Testkit protocol. This allows async driver testing using the same Testkit tests transparently.

Not all requests are implemented in this PR. For instance, the resolver implementation will be added separately. The current update enables a substantial amount of tests to be executed.

In addition, a separate PR is planned to migrate the sync backend to the new Netty based implementation.
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as agreed on after the nice introduction.

@injectives injectives merged commit 341c3a5 into neo4j:4.4 Aug 18, 2021
@injectives injectives deleted the feature/async branch August 18, 2021 14:16
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 18, 2021
This update brings async Testkit backend support that uses async driver for testing and is compatible with the current Testkit protocol. This allows async driver testing using the same Testkit tests transparently.

Not all requests are implemented in this PR. For instance, the resolver implementation will be added separately. The current update enables a substantial amount of tests to be executed.

In addition, a separate PR is planned to migrate the sync backend to the new Netty based implementation.
@bigmontz bigmontz self-requested a review August 18, 2021 15:42
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

injectives added a commit that referenced this pull request Aug 18, 2021
This update brings async Testkit backend support that uses async driver for testing and is compatible with the current Testkit protocol. This allows async driver testing using the same Testkit tests transparently.

Not all requests are implemented in this PR. For instance, the resolver implementation will be added separately. The current update enables a substantial amount of tests to be executed.

In addition, a separate PR is planned to migrate the sync backend to the new Netty based implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants