-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't prevent NodeJS from closing to run acquisition timeout error #1196
Conversation
Hej @CarsonF, there is some errors in the pipelines which I will need to investigate. Could you share the Node version you used? |
v22.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @CarsonF .
However, there is a problem with the code when running in browser, see my other comment in the PR.
Apart of this, you need to run npm run build::deno
for sync the deno version of the driver.
Thanks for your contribution, @CarsonF. The changes will be released in the version 5.22.0 of the driver. |
Currently my node process will wait 60 seconds (I know it's configurable) to close because this timeout is waiting to fire a timeout error. This stops referencing counting this callback, so it won't prevent the process from closing. This will still process if there are other executions in the event loop, so all this affects if node is waiting on a timeout that will never be needed.
Digging more into this the wait time happens because the socket never emits the logon success.
60% of the time I see
But no bytes are ever read / the data event is never fired.
This just "hangs" waiting for logon response, until the timeout is fired. I'm not sure why this happens. I haven't indicated to node in any way of my intention to close the process. Yet somehow I suspect it is aware of this.
The other 40% the logon / connection init process works fine:
In these cases the process cleans up rapidly.