Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tx timeout to be 0 and send it #841

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Conversation

robsdedude
Copy link
Member

Altering TestKit back end to treat exceptions on session.run and tx.run
as DriverErrors

Altering TestKit back end to treat exceptions on session.run and tx.run
as `DriverError`s
@robsdedude robsdedude marked this pull request as ready for review January 12, 2022 16:17
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart of the usage of != instead of !==.

packages/bolt-connection/src/bolt/request-message.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏲️ 💥

@robsdedude robsdedude merged commit 10f64b8 into neo4j:5.0 Jan 18, 2022
@robsdedude robsdedude deleted the tx-timeout branch January 18, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants