Improve error reporting on routing discovery #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routing drivers (`neo4j[+s[sc]]://` scheme) retry fetching a routing table on many different errors that are considered not retryable in the context of transactions. This is to overall improve the driver's stability when connecting to clusters. However, this poses the risk of hiding user-input errors (e.g., selecting a database name that is invalid or doesn't exist). Hence, the driver blacklists a handful of selected error codes upon which the discovery process is terminated prematurely, raising the raw error to the user. We expand the list to include more errors: * `Neo.ClientError.Statement.TypeError`, e.g., when trying to impersonate an integer. * `Neo.ClientError.Statement.ArgumentError`, e.g., when trying to impersonate without the required permissions. * `Neo.ClientError.Request.Invalid`, e.g., when trying to select an integer database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing drivers (
neo4j[+s[sc]]://scheme) retry fetching a routing table on many different errors that are considered not retryable in the context of transactions. This is to overall improve the driver's stability when connecting to clusters.However, this poses the risk of hiding user-input errors (e.g., selecting a database name that is invalid or doesn't exist). Hence, the driver blacklists a handful of selected error codes upon which the discovery process is terminated prematurely, raising the raw error to the user.
We expand the list to include more errors:
Neo.ClientError.Statement.TypeError, e.g., when trying to impersonate an integer.Neo.ClientError.Statement.ArgumentError, e.g., when trying to impersonate without the required permissions.Neo.ClientError.Request.Invalid, e.g., when trying to select an integer database.Depends on