Skip to content

Add Dockerfiles (#56) #173

Add Dockerfiles (#56)

Add Dockerfiles (#56) #173

GitHub Actions / clippy failed Dec 16, 2024 in 0s

clippy

16 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 16
Warning 0
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 26 in src/world/sign.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> src/world/sign.rs:26:6
   |
26 | impl<'a> RawSignText<'a> {
   |      ^^              ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
26 - impl<'a> RawSignText<'a> {
26 + impl RawSignText<'_> {
   |

Check failure on line 352 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/section.rs:352:6
    |
352 | impl<'a> Biomes for BiomesV0<'a> {
    |      ^^                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
352 - impl<'a> Biomes for BiomesV0<'a> {
352 + impl Biomes for BiomesV0<'_> {
    |

Check failure on line 297 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/section.rs:297:6
    |
297 | impl<'a> Biomes for BiomesV1_18<'a> {
    |      ^^                         ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
297 - impl<'a> Biomes for BiomesV1_18<'a> {
297 + impl Biomes for BiomesV1_18<'_> {
    |

Check failure on line 245 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

error: manually reimplementing `div_ceil`
   --> src/world/section.rs:245:26
    |
245 |             let expected_length = (64 + biomes_per_word - 1) / biomes_per_word;
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `64.div_ceil(biomes_per_word)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

Check failure on line 191 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/section.rs:191:6
    |
191 | impl<'a> Section for SectionV0<'a> {
    |      ^^                        ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
191 - impl<'a> Section for SectionV0<'a> {
191 + impl Section for SectionV0<'_> {
    |

Check failure on line 148 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/section.rs:148:6
    |
148 | impl<'a> Section for SectionV1_13<'a> {
    |      ^^                           ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
148 - impl<'a> Section for SectionV1_13<'a> {
148 + impl Section for SectionV1_13<'_> {
    |

Check failure on line 84 in src/world/section.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

error: manually reimplementing `div_ceil`
  --> src/world/section.rs:84:5
   |
84 |                 (4096 + blocks_per_word - 1) / blocks_per_word
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `4096.div_ceil(blocks_per_word)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
   = note: `-D clippy::manual-div-ceil` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::manual_div_ceil)]`

Check failure on line 61 in src/world/layer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> src/world/layer.rs:61:6
   |
61 | impl<'a> LayerEntry<'a> {
   |      ^^             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
61 - impl<'a> LayerEntry<'a> {
61 + impl LayerEntry<'_> {
   |

Check failure on line 436 in src/world/chunk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/chunk.rs:436:6
    |
436 | impl<'a> FusedIterator for SectionIter<'a> {}
    |      ^^                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
436 - impl<'a> FusedIterator for SectionIter<'a> {}
436 + impl FusedIterator for SectionIter<'_> {}
    |

Check failure on line 425 in src/world/chunk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/chunk.rs:425:6
    |
425 | impl<'a> ExactSizeIterator for SectionIter<'a> {
    |      ^^                                    ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
425 - impl<'a> ExactSizeIterator for SectionIter<'a> {
425 + impl ExactSizeIterator for SectionIter<'_> {
    |

Check failure on line 419 in src/world/chunk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/world/chunk.rs:419:6
    |
419 | impl<'a> DoubleEndedIterator for SectionIter<'a> {
    |      ^^                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
419 - impl<'a> DoubleEndedIterator for SectionIter<'a> {
419 + impl DoubleEndedIterator for SectionIter<'_> {
    |

Check failure on line 160 in src/core/tile_mipmapper.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
   --> src/core/tile_mipmapper.rs:160:6
    |
160 | impl<'a> TileCollector for TileMipmapper<'a> {
    |      ^^                                  ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
160 - impl<'a> TileCollector for TileMipmapper<'a> {
160 + impl TileCollector for TileMipmapper<'_> {
    |

Check failure on line 77 in src/core/tile_mipmapper.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> src/core/tile_mipmapper.rs:77:6
   |
77 | impl<'a, P: image::PixelWithColorType> TileMerger for MapMerger<'a, P>
   |      ^^                                                         ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
77 - impl<'a, P: image::PixelWithColorType> TileMerger for MapMerger<'a, P>
77 + impl<P: image::PixelWithColorType> TileMerger for MapMerger<'_, P>
   |

Check failure on line 37 in src/core/entity_collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> src/core/entity_collector.rs:37:6
   |
37 | impl<'a> TileCollector for EntityCollector<'a> {
   |      ^^                                    ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
37 - impl<'a> TileCollector for EntityCollector<'a> {
37 + impl TileCollector for EntityCollector<'_> {
   |

Check failure on line 19 in src/core/entity_collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

error: the following explicit lifetimes could be elided: 'a
  --> src/core/entity_collector.rs:19:6
   |
19 | impl<'a> TileMerger for EntityCollector<'a> {
   |      ^^                                 ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
   |
19 - impl<'a> TileMerger for EntityCollector<'a> {
19 + impl TileMerger for EntityCollector<'_> {
   |

Check failure on line 22 in src/core/common.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

error: empty line after doc comment
  --> src/core/common.rs:21:1
   |
21 | / /// Increase to force regeneration of all output files
22 | |
   | |_
...
27 |   pub const REGION_FILE_META_VERSION: FileMetaVersion = FileMetaVersion(2);
   |   --------------------------------------------------- the comment documents this constant
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
   = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
   = help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
   |
22 | ///
   |