Removed mention of resolved issue. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to use a run group instead of a run in eclipse. |
|
Oh, it should be mentioned as well then. |
|
Dewit |
Technici4n
reviewed
Jan 21, 2024
Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
Technici4n
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my previous PR(#17) Issue regarding run config was mentioned. However
*ideBeforeRuntasks are not visible on Eclipse, so no one actually can run it. And it did not specify task names are prepended by run config names such asclientIdeBeforeRunI deleted
.classpath .eclipse .project .settingsfrom MDK and reimported it on Eclipse and run config worked withoutrunClienttask. Although preprocessor didn't ran, so I pulled my other mod's toml. but it was not related to the pointed out issue.Can anybody else also test it out as well?