Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cargo-cp-artifact): Hotfix for change in cargo diagnostics naming #1039

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(cargo-cp-artifact): Hotfix for change in cargo diagnostics naming #1039

merged 1 commit into from
May 10, 2024

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented May 8, 2024 •
edited
Loading

Fix for a change in cargo behavior to use the snake_case name in artifacts.

rust-lang/cargo#13867

dherman
dherman approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I made a couple presentational suggestions.

RELEASES.md Outdated Show resolved Hide resolved
pkgs/cargo-cp-artifact/src/index.js Show resolved Hide resolved
@kjvalencik kjvalencik force-pushed the kv/cp-artifact-hotfix branch from f0b4e41 to a328375 Compare May 10, 2024 16:16
@kjvalencik kjvalencik merged commit 91427d2 into main May 10, 2024
9 checks passed
@kjvalencik kjvalencik deleted the kv/cp-artifact-hotfix branch May 10, 2024 16:26
@dherman dherman mentioned this pull request May 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman