Make build() fn's closure return a Result #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
reviewed
Sep 9, 2024
| @@ -59,18 +59,13 @@ pub use self::promise::JsFuture; | |||
|
|
|||
| // This should be considered deprecated and will be removed: | |||
There was a problem hiding this comment.
It was noted; I hadn't seen a plan for removal and went for a safe refactor that enabled what I really wanted: infallible JsError::error. Is that end goal even possible and, if so, is it worth blocking on the larger cleanup for?
|
While I appreciate the refactor--cleaning up is always good for maintenance!--the Since it shouldn't be used in anything new and should eventually be completely removed, I would prefer not to change it. This is likely where I would start in that refactor. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactor that makes the
buildfunction more idiomatic; no externally-facing types or functions are changed. The big benefit here is that it makes it possible to, in a future change, make the return type of some functions infallible, likeJsError::error.