fix(neon): Relax lifetime constraints on With
and provide helper for forcing HRTB with JS values
#1086
+112
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
is primarily intended as a helper for providing a thunk executed on the main thread after an asynchronous operation. However, it's not currently possible to return JavaScript values due to unnecessarily restrictive lifetimes.These changes relax thoe bounds, but unfortunately causes Rust to no longer correctly infer the correct HRTB. As a workaround, an
extract::with
helper is provided.I could not find a way to make a helper that works with both
JsResult
and Rust data without a lifetime. Since someone returning Rust data always has the option to call.try_into_js(cx)
, I chose to keep the API simple by only providing the one helper.Open Questions
O: TryIntoJs<'cx>
that aren't'static
?With
private? Thewith
type would return an opaqueimpl for<'cx> TryIntoJs<'cx>
. This could simplify the API.