Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Flush content cache on rebase workspace #5254

Merged
merged 5 commits into from
Sep 19, 2024
Merged

BUGFIX: Flush content cache on rebase workspace #5254

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
889b61e
TASK: Add test case for cache flushing on rebase workspace
dlubitz Sep 19, 2024
30382b3
TASK: Flush content cache of workspace on a workspace rebase
dlubitz Sep 19, 2024
44866e7
TASK: Improve performance and skip flushing single node aggregates if…
dlubitz Sep 19, 2024
1f9ad38
TASK: Inline method `hasMatchingFlushWorkspaceRequest`
mhsdesign Sep 19, 2024
4396f07
TASK: Formatting
dlubitz Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Neos.Neos/Classes/Fusion/Cache/GraphProjectorCatchUpHookForCacheFlushing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ public function onAfterCatchUp(): void
{
foreach ($this->flushNodeAggregateRequestsOnAfterCatchUp as $request) {
// We do not need to flush single node aggregates if we flush the whole workspace anyway.
if (!$this->hasMatchingFlushWorkspaceRequest($request)) {
if (!isset($this->flushWorkspaceRequestsOnAfterCatchUp[$request->workspaceName->value])) {
dlubitz marked this conversation as resolved.
Show resolved Hide resolved
$this->contentCacheFlusher->flushNodeAggregate($request, CacheFlushingStrategy::IMMEDIATE);
}
}
Expand All @@ -275,9 +275,4 @@ public function onAfterCatchUp(): void
}
$this->flushWorkspaceRequestsOnAfterCatchUp = [];
}

private function hasMatchingFlushWorkspaceRequest(FlushNodeAggregateRequest $request): bool
{
return isset($this->flushWorkspaceRequestsOnAfterCatchUp[$request->workspaceName->value]);
}
}
Loading