-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node creation dialog element labels translation not working #1539
Comments
Just to let everyone know: I'm currently working on this. Most of it needs to be adapted inside neos/neos. |
Depends on a change for neos/neos-development-collection Fixes: neos#1539
I added this functionality for the label of the creationDialog elements. I'm not sure if the syntax inside the XLF file is OK, e.g. |
At the same time and as an example I made the |
In the same time, the "Title" label for a new Document node is added to the language files. The creationDialog configuration for this node type is inside Neos.Neos.Ui. Fixes: neos/neos-ui#1539
The declaration `showInCreationDialog` was copied over from Neos.Neos and the explicit configuration of `creationDialog.elements.title` is obsolete. The explicit declaration of ui.label: i18n would lead to `Neos.Neos:NodeTypes.Document:creationDialog.title` instead of `Neos.Neos:NodeTypes.Document:properties.title` being used. That made it hard to set a simple title as the translation was more eager. Resolves #3509 The previously used creationDialog translation is now obsolete (resided in Neos.Neos) See also #1539
The declaration `showInCreationDialog` was copied over from Neos.Neos and the explicit configuration of `creationDialog.elements.title` is obsolete. The explicit declaration of ui.label: i18n would lead to `Neos.Neos:NodeTypes.Document:creationDialog.title` instead of `Neos.Neos:NodeTypes.Document:properties.title` being used. That made it hard to set a simple title as the translation was more eager. Resolves #3509 The previously used creationDialog translation is now obsolete (resided in Neos.Neos) See also #1539
Seems labels with value "i18n" are not translated. Instead "i18n" is used as a fixed value.
Steps to reproduce:
Expected result:
I see the element in the dialog with a translated label (or at least the i18n-key as fallback if no translation exists yet.
Actual result:
The string "i18n" is used as label:
The text was updated successfully, but these errors were encountered: