TASK: Fix e2e tests #2928
Merged
TASK: Fix e2e tests #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebaldi
force-pushed
the
task/fixE2eTests
branch
from
784147f
to
4f8487f
Compare
grebaldi
force-pushed
the
task/fixE2eTests
branch
from
4f8487f
to
2f5ab57
Compare
|
@grebaldi As neos/neos-development-collection#3368 is merged we can remove the Draft mode or not? Thanks for working the whole sunday 🙏 |
markusguenther
approved these changes
Jul 27, 2021
|
Hi @markusguenther, the changes in here were supposed to go to some of the lower branches as well. But since none of them were actually the cause for the E2E tests failing, I think we can also leave it as-is. Wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Failures were related to a Guzzle deprecation fixed in neos/neos-development-collection#3368
An unfixed version of Neos.Fusion got stuck in the CircleCI cache. Resetting cache keys as described in https://github.com/neos/neos-ui#just-the-end-to-end-tests-fail fixed that.