-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Support preview uris in datasource selectboxeditor #2930
FEATURE: Support preview uris in datasource selectboxeditor #2930
Conversation
f14de2b
to
fa03d4f
Compare
fa03d4f
to
5c90579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works pretty fine and is a great improvement for the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice addition, like always ❤️
In contrast to your plugin Shel.Neos.PreviewSelectBox this seems to works only for data sources, not for manually defined values, is that on purpose?
|
I guess it should be a in the format of a flow resource stream wrapper: |
No, neither version works |
Hi @JPLudin, both my plugin and this change do the same, and both mention that you should absolute URIs, as relative URIs are not reliable. You can check in the dev tools which uri it tries to open and then adjust your uri. Or use a datasource and properly resolve it to absolute Uris to have no problem with environments/hosting, etc. |
@Sebobo As described above, exactly this code works with your plugin, but not with the code. |
What I did
Options returned from a datasource can now contain a
preview
with an absolute image uri which will then be shown in the dropdown.How I did it
Use new option component supporting previews for data source based selectboxeditor.
Works almost identically to the AssetOption of the AssetEditor.
How to verify it
Also added a test.
Resolves: #2914