BUGFIX: Ensure that only numerical property values are converted to integer

[grebaldi]

fixes: #3158, #3157

The problem

The UI's NodePropertyConversionService over-generalizes when converting incoming values to integer. It just casts any incoming string to int via (int) $someValue.

Now, PHP throws no error if the value we're casting to int actually cannot be meaningfully converted. So, pretty much anything it cannot make sense of ends up being 0:

php > echo (int) "foo";
0

The solution

I adjusted the method convertInteger of NodePropertyConversionService to only convert strings to integers that pass PHP's is_numerical check.

In case the string doesn't pass, convertInteger now defaults to null.

Because of this, I needed to adjust the TextFieldEditor component, so that it now handles the occurrence of null-values correctly.

As a result, if I enter a non-numerical string into a text field for a property of type integer, the property will receive null as a value. The same thing happens, if I enter an empty string.

[mhsdesign]

Thanks you ;)
Looks good for know. In the future (Neos 9) id like to have strict validation via ajax directly in the editor. (And we could make our NodePropertyConversion thing more strict by throwing exceptions ...)

[mhsdesign]

Tested it, and after fixing also the TextAreaEditor to handle null as value it works as expected:

before

Bildschirmaufnahme.2023-07-05.um.08.15.44.mov

after

Bildschirmaufnahme.2023-07-05.um.08.26.15.mov

[bwaidelich]

I think the more annoying issue (that ought to be fixed for LTS imho) is #3157 (unsetting an optional integer value is impossible).

Very good point, take my vote :)