BUGFIX: Ensure that SecondaryInspector is always above UnappliedChanges-overlay #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es-overlay Also: Add failing e2e test for regression from 3491
mhsdesign
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2670
The Problem
This one fixes a regression introduced in #3491 (see also: #3491 (comment)).
There, the global z-Index of the "unapplied changes"-overlay has been increased, so that it covers the entire UI (minus the inspector). By accident, the "unapplied changes"-overlay now also covers the secondary inspector.
This, of course, leads to quite irritating problems. For example:
When I try to crop an Image, I will succeed at dragging the crop handle at first. Any additional click inside the secondary inspector however will trigger the "unapplied changes"-dialog.
The solution
I adjusted the "image editor" E2E test, so that it now captures the interference between the secondary inspector and the "unapplied changes"-overlay. Then I changed all relevant z-Indices, so that the interference stops.