build(tests): type check Buffer.test.ts #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping with this! Probably want to do a couple files at a time, not one big PR. |
gjf7
force-pushed
the
test-files-ts-check
branch
from
5a3ca59 to
46e1cad
Compare
justinmk
reviewed
Oct 9, 2024
justinmk
reviewed
Oct 9, 2024
justinmk
approved these changes
Oct 9, 2024
gjf7
force-pushed
the
test-files-ts-check
branch
from
46e1cad to
3d0e522
Compare
gjf7
changed the title
gjf7
force-pushed
the
test-files-ts-check
branch
from
3d0e522 to
8e287ad
Compare
justinmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #352
Our linter and TypeScript config disagreed on test files. Linter included them, config didn't.
node-client/packages/neovim/tsconfig.json
Line 7 in 65ddb5e
node-client/package.json
Line 37 in 65ddb5e
This PR should fix this as well.