Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transport): high-traffic RPC #412

Merged
merged 1 commit into from
Oct 17, 2024
Merged

test(transport): high-traffic RPC #412

merged 1 commit into from
Oct 17, 2024

Conversation

justinmk
Copy link
Member

@justinmk justinmk commented Oct 10, 2024

Problem:

In vscode-neovim/vscode-neovim#2184 (comment) it was reported that "Github Copilot Chat opens MANY buffers while writing code, and that somehow breaks the vscode-neovim extension".

Solution:

  • Add test coverage for high amounts of RPC traffic.
  • TODO: this doesn't cover complex scenarios such as a looping OptionSet handler.

    Steps to Reproduce: Ask Github Copilot Chat to generate some code. This will create a bunch of visible windows, and seemingly overload the neovim plugin, causing it to freeze and usually get the warning that cleanup takes too long. It never seems to recover.

Problem:
In
vscode-neovim/vscode-neovim#2184 (comment)
it was reported that "Github Copilot Chat opens MANY buffers while
writing code, and that somehow breaks the vscode-neovim extension".

Solution:
- Add test coverage for high amounts of RPC traffic.
- TODO: this doesn't cover complex scenarios such as a looping
  `OptionSet` handler.
@justinmk justinmk merged commit 52e5d1a into master Oct 17, 2024
10 checks passed
@justinmk justinmk deleted the fixtransport branch October 17, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant