-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename "server_configurations" => "configs" #3330
Conversation
Problem: The name `server_configurations` is extremely verbose and irritatingly formal and dogmatic. This overlong name is a constant nuisance when reading, writing, and coding. It's also not even correct: these configurations are just as much "client" configurations as they are "server" configurations. Solution: - Rename to a shorter name. - Leave placeholder files for any old URLs that link to the old location.
Note that |
This should probably be a Not that it matters much, but it makes it harder to follow changes to the code here :) |
I am surprised to see code like https://github.com/LazyVim/lazyvim.github.io/blob/cfb8baecfa4ef136abe8a40d807ade3a9d3be438/docs/extras/lang/tailwind.md?plain=1#L55
The documented way to use configs has always been:
But I can add a compatibility shim if this change breaks things. |
Thanks for your response @justinmk! In my case, I want to get and reuse some default ESLint configs, specifically the Before I used: local eslint_default = require("lspconfig.server_configurations.eslint").default_config Now I've changed it to: local eslint_default = require("lspconfig").eslint.document_config.default_config It works, but |
…on changes See: neovim/nvim-lspconfig#3330 This is currently breaking when using main branch by default due to: williamboman/mason-lspconfig.nvim#469
Ok, I see that use-case is to get a config definition without activating it. I added (ideally this field wouldn't be needed, the result of |
Can confirm the new |
Can confirm, it just broke my plugin 5 minutes ago and confused me lol. |
Problem:
The name
server_configurations
is extremely verbose and irritatingly formal and dogmatic. This overlong name is a constant nuisance when reading, writing, and coding.It's also not even correct: these configurations are just as much "client" configurations as they are "server" configurations.
Solution: