feat(lspinfo): print "{cmd} --version", drop config.lspinfo #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2024
Problem: `config.lspinfo` is an undocumented feature that allows extending the info shown in `:LspInfo` (`:checkhealth lspconfig`). This feature is unwanted because: - it's undocumented - it adds a maintenance burden - it provides info that should be derived from the LSP protocol itself. Solution: Remove support for `config.lspinfo`. Instead, `:LspInfo` (`:checkhealth lspconfig`) should be enhanced to automatically gather this kind of extra info from the server response.
|
Note that |
justinmk
commented
Oct 18, 2024
| local info_lines = { | ||
| 'filetypes: ' .. config_info.filetypes, | ||
| 'root directory: ' .. fmtpath(config_info.root_dir), | ||
| 'cmd: ' .. fmtpath(config_info.cmd), | ||
| ('%-18s `%s`'):format('version:', try_get_version(cmd_version)), |
There was a problem hiding this comment.
Print the cmd --version result automatically.
justinmk
changed the title
glepnir
reviewed
Oct 18, 2024
| --- @param cmd string[] | ||
| local function try_get_version(cmd) | ||
| local out = vim.fn.system(cmd) | ||
| if not out then |
There was a problem hiding this comment.
Suggested change
| if not out then | |
| if not out or vim.v.shell_error > 0 then |
do we also need this condition 🤔
There was a problem hiding this comment.
if it returns any output we'll just print it, regardless of error code
dundargoc
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
config.lspinfois an undocumented feature that allows extending the info shown in:LspInfo(:checkhealth lspconfig). This feature is unwanted because:Solution:
config.lspinfo.:LspInfo(:checkhealth lspconfig) should be enhanced to automatically gather this kind of extra info from the server response. can :LspInfo (:checkhealth lspconfig) show more detailed info? #3376