Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano tutorial needs update #237

Open
jarlebring opened this issue Dec 19, 2019 · 2 comments
Open

nano tutorial needs update #237

jarlebring opened this issue Dec 19, 2019 · 2 comments

Comments

@jarlebring
Copy link
Member

jarlebring commented Dec 19, 2019

There is a new version of the online code from G Demesy that we base our nano-tutorial on. The tutorial still works, but you would need to go back to an old version of his code. We should update the nano-tutorial to use the new version of the code (i.e. update the simulation output as well as the modification description). In order to not have to do this again if they decide to update the code again, I propose we now provide a URL pointer to their code directly to to the current commit (not newest), i.e something like:

https://gitlab.onelab.info/doc/models/tree/be2c09ebd6c3109e6ca2a703c2e5ae54abf16cea/NonLinearEVP

jarlebring added a commit that referenced this issue Dec 19, 2019
@jarlebring
Copy link
Member Author

In the previous commit I changed the URL-link to a specific (old version) of their code, so the tutorial works exactly as explained. It is still probably a good idea to update the tutorial to the new version of their code.

@jarlebring
Copy link
Member Author

If we are anyway going through the tutorial again, we might as well also update and use https://github.com/tkonolige/PETScBinaryIO.jl instead of our own crude implementation of reading sparse PETSc-matrices. Note that you need to provide the correct kwargs to readpetsc:

Z=readpetsc("file_mat_M15.m.bin",int_type=Int32,scalar_type=ComplexF64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant