Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disktype in nodepool #12

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

anurag-rajawat
Copy link
Contributor

@anurag-rajawat anurag-rajawat commented Dec 19, 2023

While experimenting with nephio on GCP we are hitting the Persistent Disk SSD (GB) quota limit because GKE clusters are default provisioned with persistent SSD disk. So by using the Standard Persistent Disk disk-type, we won't hit these resource quota limit because it is cheaper and has a higher quota.

For more context: https://nephio.slack.com/archives/C03L6Q8LFHD/p1702393618611819

Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Copy link

linux-foundation-easycla bot commented Dec 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: anurag-rajawat / name: Anurag Rajawat (2b4b0ce)

@johnbelamaric
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anurag-rajawat, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Dec 19, 2023
@nephio-prow nephio-prow bot merged commit 7a90cd0 into nephio-project:main Dec 19, 2023
2 checks passed
@anurag-rajawat anurag-rajawat deleted the update-disk-type branch December 20, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants