Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add porch package #13

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add porch package #13

merged 2 commits into from
Jan 8, 2024

Conversation

johnbelamaric
Copy link
Member

Migrate the Porch kpt package from nephio-example-packages, and update to v0.0.35, served from the nephio Docker hub.

In a later iteration, we will update to a build made from the nephio-project/porch repository.

Copy link
Contributor

nephio-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Dec 19, 2023
@johnbelamaric
Copy link
Member Author

Changed the images to use :latest. I am thinking maybe it should be part of our release process to set it the specific tag. Not sure though.

@johnbelamaric
Copy link
Member Author

Oh, the reason for the change to :latest is to use the images that include the fix to nephio-project/nephio#451 - alternatively I have tagged those images as "v2.0.0-beta.1", assuming R2 will use v2.0.0, and that R2 will use those Porch images built from the nephio-project/porch repo.

@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 8, 2024
@nephio-prow nephio-prow bot merged commit 6973395 into nephio-project:main Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants