Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nephio-controllers from examples to core #14

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

johnbelamaric
Copy link
Member

And rename to nephio-operator, update image tag to :latest.

And rename to nephio-operator, update image tag to :latest.
Copy link
Contributor

nephio-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Victor Morales <chipahuac@hotmail.com>
@electrocucaracha
Copy link
Member

electrocucaracha commented Jan 9, 2024

@johnbelamaric isn't redundant to call this package nephio-operator given that it lives under the nephio folder? What about just operator like the nephio/core/operator folder?

At the end, users can clone it with whatever name that they prefer

@johnbelamaric
Copy link
Member Author

At the end, users can clone it with whatever name that they prefer

True, so we could do as you suggest. My only (minor) concerns with that would be how it appears in lists (though the repo should be with it) and whether people cloning it would by default keep the same name (which is super generic).

I am ok either way, though. Anyone else have an opinion?

@electrocucaracha
Copy link
Member

Ok, we can create a topic in the GitHub discussion to evaluate pros and cons. I think for now we can merge this one

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 9, 2024
@nephio-prow nephio-prow bot merged commit b437d48 into nephio-project:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants