Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix free5gc-operator-role RBAC #24

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Fix free5gc-operator-role RBAC #24

merged 9 commits into from
Jan 18, 2024

Conversation

lapentad
Copy link
Contributor

WIP

  1. Updated nfdeploy-fn docker image
  2. Added Roles for nfdeployments and nfconfigs
  3. Adjusted privileges

@nephio-prow nephio-prow bot requested review from s3wong and tliron January 18, 2024 07:28
@lapentad lapentad changed the title Update free5gc packages WIP Update free5gc packages Jan 18, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 18, 2024

@lapentad: No presubmit jobs available for nephio-project/catalog@main

In response to this:

/test e2e-free5gc-ubuntu-focal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@electrocucaracha
Copy link
Member

electrocucaracha commented Jan 18, 2024 •
edited
Loading

@lapentad do we need to include the NFDeployment and NFConfig CRDs? Those are also used by OAI

@lapentad
Copy link
Contributor Author

I Removed them now

@electrocucaracha
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Jan 18, 2024
@electrocucaracha
Copy link
Member

/retitle Fix free5gc-operator-role RBAC

@nephio-prow nephio-prow bot changed the title WIP Update free5gc packages Fix free5gc-operator-role RBAC Jan 18, 2024
@henderiw
Copy link

/lgtm
/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, henderiw, lapentad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jan 18, 2024
@nephio-prow nephio-prow bot merged commit 49282de into nephio-project:main Jan 18, 2024
2 checks passed
@efiacor efiacor deleted the update-free5gc branch July 10, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3wong s3wong Awaiting requested review from s3wong

@tliron tliron Awaiting requested review from tliron

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@arora-sagar arora-sagar Awaiting requested review from arora-sagar

Assignees

@electrocucaracha electrocucaracha

@henderiw henderiw

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lapentad @electrocucaracha @henderiw