Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI e2e tests #10

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

johnbelamaric
Copy link
Member

This adds the CLI E2E tests. A couple notes:

  • Like the other e2e tests, in order to run you need to create a cluster and deploy porch, and set E2E=1
  • These require that porchctl is built and in the path.
  • Currently they also require that kpt is built and in the path, because a few tests execute kpt fn. There is no need to have a version of kpt with kpt alpha commands, just kpt fn.

I manually ran the e2e tests in this PR.

Copy link
Contributor

nephio-prow bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnbelamaric johnbelamaric merged commit 227e490 into nephio-project:main Dec 20, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant