-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render status cleanup through "PorchFile" implementation #108
base: main
Are you sure you want to change the base?
Render status cleanup through "PorchFile" implementation #108
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1st Problem (Not Efficient): |
2nd Problem (Failing Tests): |
This PR is an amalgamation of 3 separate issues, these being
nephio-project/nephio#699,
nephio-project/nephio#603,
nephio-project/nephio#783
The first 2 mainly address the render status of a porch package, at the moment the render status is not propagating down to the PackageRevisionResources and always returns an exit code 0 status even when a rendering issue was encountered (#603).
An Improvement in the returned render status data as per (#603 & #699). It achieves this propagating metadata such as the latest render status to a "PorchFile" suggested by @kispaljr in (#783).
This solution does "work" in the sense that it is able to accomplish what I've mentioned above however there are 2 main problems and as the discussion in (#783) is still ongoing i wish to open this up to suggestions/opinions.