Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gotests in makefile to latest version #48

Merged
merged 2 commits into from
May 15, 2024

Conversation

liamfallon
Copy link
Member

Update the gotests image in the makefile to be compatible with the latest go version.

@nephio-prow nephio-prow bot requested review from henderiw and tliron May 14, 2024 12:36
@nephio-prow nephio-prow bot added the approved label May 14, 2024
@efiacor
Copy link
Collaborator

efiacor commented May 14, 2024

Clever. Seems the change doesn't trigger a unit test run. Hmmm
https://github.com/nephio-project/porch/blob/main/.prow.yaml#L4

@liamfallon
Copy link
Member Author

Clever. Seems the change doesn't trigger a unit test run. Hmmm https://github.com/nephio-project/porch/blob/main/.prow.yaml#L4

Yes, you'd want to run the tests in this case.

@efiacor
Copy link
Collaborator

efiacor commented May 14, 2024

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Collaborator

efiacor commented May 14, 2024

Clever. Seems the change doesn't trigger a unit test run. Hmmm https://github.com/nephio-project/porch/blob/main/.prow.yaml#L4

Yes, you'd want to run the tests in this case.

I pushed a change in subsequent PR #50

@radoslawc radoslawc closed this May 14, 2024
@radoslawc radoslawc reopened this May 14, 2024
@efiacor efiacor closed this May 15, 2024
@efiacor efiacor reopened this May 15, 2024
@efiacor
Copy link
Collaborator

efiacor commented May 15, 2024

/lgtm

@nephio-prow nephio-prow bot removed the lgtm label May 15, 2024
@efiacor
Copy link
Collaborator

efiacor commented May 15, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 15, 2024
@nephio-prow nephio-prow bot merged commit 5d1e091 into nephio-project:main May 15, 2024
5 checks passed
@efiacor efiacor deleted the update-gotests-in-make branch May 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants