#588 - Add missing repository rbac roles for porch controllers #56
Conversation
Signed-off-by: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>
kushnaidu
requested review from
liamfallon,
efiacor and
Catalin-Stratulat-Ericsson
|
Could you add some context around this PR please? |
just updated the PR description |
Signed-off-by: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>
|
/approve Looks fine to me but let's get some more reviews. |
Signed-off-by: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>
|
/lgtm |
|
@nagygergo: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson, kushnaidu, liamfallon, nagygergo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This change adds missing repository rbac roles for the porch controllers.
Context -
The use cases are working, but after someone creates a PVS or PV and points to a repo, the controller logs are populated with errors saying the controllers cannot 'get' the repositories.