Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fail fast CI feature to reduce the End-to-End testing consumption #230

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Enable fail fast CI feature to reduce the End-to-End testing consumption #230

merged 10 commits into from
Jan 25, 2024

Conversation

electrocucaracha
Copy link
Member

@electrocucaracha electrocucaracha commented Jan 11, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
The current test-infra End-to-End testing behavior continues executing tests until the end. In some cases, this could extend the testing time and block or misuse the CI resources. This change enables a feature to stop the End-to-End execution if a failure is previously raised.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@electrocucaracha electrocucaracha force-pushed the improve_periodic branch 2 times, most recently from dc7188a to 521cc05 Compare January 11, 2024 18:44
@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow nephio-prow bot added the approved label Jan 12, 2024
@arora-sagar
Copy link
Contributor

@electrocucaracha To test this don't we need new porch version. With old version it will always fail and will have timeout. As porch is not able to find the sub-directories.

@electrocucaracha electrocucaracha mentioned this pull request Jan 15, 2024
Merged
@electrocucaracha electrocucaracha changed the title Use main branch and fail_fast in on demand CI tasks Enable fail fast CI feature to reduce the End-to-End testing consumption Jan 17, 2024
@electrocucaracha
Copy link
Member Author

/retest

@lapentad
Copy link
Contributor

@electrocucaracha nice catch on the free5gc reconciler!
005.sh passed and 006.sh failed I wonder if it's a timing issue

@electrocucaracha
Copy link
Member Author

@electrocucaracha nice catch on the free5gc reconciler! 005.sh passed and 006.sh failed I wonder if it's a timing issue

I'm experimenting with different VM flavors to see if there is an improvement on provisioning, but in the meantime we need to merge the two PRs in the Catalog repo

@radoslawc
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 22, 2024
arora-sagar
arora-sagar reviewed Jan 22, 2024
View reviewed changes
.prow.yaml Outdated Show resolved Hide resolved
@nephio-prow nephio-prow bot removed the lgtm label Jan 22, 2024
@electrocucaracha
Copy link
Member Author

/retest

2 similar comments
@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

2 similar comments
@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

@electrocucaracha electrocucaracha mentioned this pull request Jan 25, 2024
Merged
@electrocucaracha
Reduce the CI time enabling failing fast feature
93a478e 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Increase e2e timeout to 120min
014493f 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Improve kpt info messages
e68bc68 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Enable fail fast feature in Vagrant deployments
1388c60 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Increase waiting time for upf-edge0 deployment
2237a65 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Drop nephio_pkg_version terraform variable
e8b722e 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Implement porch_wait_published_packagerev test function
17f0c15 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Improve waiting time in 004.sh free5gc test
6720bce 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Fix OAI test script formats
0cc4664 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Remove corrupted APT files
d12b233 
Signed-off-by: Victor Morales <v.morales@samsung.com>
@efiacor
Copy link
Contributor

efiacor commented Jan 25, 2024

/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Contributor

efiacor commented Jan 25, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 25, 2024
@nephio-prow nephio-prow bot merged commit 7a82a1f into nephio-project:main Jan 25, 2024
8 checks passed
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 25, 2024

@electrocucaracha: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
The current test-infra End-to-End testing behavior continues executing tests until the end. In some cases, this could extend the testing time and block or misuse the CI resources. This change enables a feature to stop the End-to-End execution if a failure is previously raised.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@electrocucaracha electrocucaracha deleted the improve_periodic branch January 25, 2024 22:01
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
@electrocucaracha @dkosteck
Enable fail fast CI feature to reduce the End-to-End testing consum…
15b8f3a 
…ption (nephio-project#230)

* Reduce the CI time enabling failing fast feature

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Increase e2e timeout to 120min

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Improve kpt info messages

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Enable fail fast feature in Vagrant deployments

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Increase waiting time for upf-edge0 deployment

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Drop nephio_pkg_version terraform variable

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Implement porch_wait_published_packagerev test function

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Improve waiting time in 004.sh free5gc test

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Fix OAI test script formats

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Remove corrupted APT files

Signed-off-by: Victor Morales <v.morales@samsung.com>

---------

Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arora-sagar arora-sagar arora-sagar left review comments

@radoslawc radoslawc Awaiting requested review from radoslawc

@vjayaramrh vjayaramrh Awaiting requested review from vjayaramrh

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@radoslawc radoslawc

@efiacor efiacor

Labels
approved kind/feature lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@electrocucaracha @radoslawc @arora-sagar @lapentad @efiacor