feat: warning for waiting too long for the next block #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initially, I think a warning log is enough. But I found that the default log filter of env-logger is "error", which means warning logs are invisible by default. So I change to use "error" logl-evel. |
quake
reviewed
May 27, 2022
src/service.rs
Outdated
| { | ||
| if let Ok(ckb_tip_header) = get_tip_header(&rpc_client).await { | ||
| error!( | ||
| "ckb-indexer has been {}s since the last update, ckb.tip_number = {}, ckb.tip_hash = {:#x}, indexer.tip_number = {}, indexer.tip_hash = {:#x}", |
There was a problem hiding this comment.
this error message ckb-indexer has been 60s since the last update, doesn't read like a complete sentence
There was a problem hiding this comment.
Force push 5b467ca updates:
- rewrite "ckb-indexer has been 60s since the last update" to "it has been 60s since the last update"
keroro520
force-pushed
the
warn-for-no-update-for-long-time
branch
from
b3e6b00
to
5b467ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prints warning logs when ckb-indexer has been too long since the last update of new blocks.