Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group_by_transaction search option #55

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

quake
Copy link
Member

@quake quake commented Jul 5, 2022

This PR added a group_by_transaction option to get_transactions rpc, resolve #21

@quake quake requested a review from doitian July 5, 2022 05:18
README.md Outdated Show resolved Hide resolved
last_cursor - pagination parameter

#### Examples

get transactions by lock script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no example for the return result. It's hard to tell how the enum looks like as JSON.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All rpc methods currently have no examples of returning results, let me fix it in a new PR.

README.md Show resolved Hide resolved
Co-authored-by: ian <ian@nervos.org>
src/service.rs Show resolved Hide resolved
@quake quake merged commit 323b550 into master Jul 8, 2022
@quake quake deleted the quake/group_by_transaction branch July 11, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new rpc for unique tx hashes
3 participants