Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit should be greater than 0 #63

Merged
merged 1 commit into from
Nov 15, 2022
Merged

chore: limit should be greater than 0 #63

merged 1 commit into from
Nov 15, 2022

Conversation

quake
Copy link
Member

@quake quake commented Nov 15, 2022

No description provided.

@quake quake mentioned this pull request Nov 15, 2022
Merged
@quake quake merged commit cd5039f into master Nov 15, 2022
bors bot added a commit to nervosnetwork/ckb that referenced this pull request Nov 15, 2022
@bors @quake
Merge #3704
341898d 
3704: chore: limit should be greater than 0 r=zhangsoledad a=quake

<!--
Thank you for contributing to nervosnetwork/ckb!

If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two.

PR Title Format:
1. module [, module2, module3]: what's changed
2. *: what's changed
-->

### What problem does this PR solve?

backport nervosnetwork/ckb-indexer#63

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)

```
curl http://localhost:8114/ -X POST -H "Content-Type: application/json" -d '{
    "jsonrpc": "2.0",
    "method": "get_transactions",
    "params": [
        {
            "script": {
                "code_hash": "0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8",
                "hash_type": "type",
                "args": "0x5f58632a123e7e731db0b59ce50fe16579c7d941"
            },
            "script_type": "lock",
            "group_by_transaction": true
        },
        "desc",
        "0x0"
    ],
    "id": 1
}'
```

### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. -->

```release-note
None: Exclude this PR from the release note.
```



Co-authored-by: quake <quake.wang@gmail.com>
@quake quake deleted the quake/check-limit branch February 15, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@quake