Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor address #143

Merged
merged 28 commits into from
Jul 15, 2022
Merged

feat: refactor address #143

merged 28 commits into from
Jul 15, 2022

Conversation

fjchen7
Copy link
Contributor

@fjchen7 fjchen7 commented Jul 14, 2022

No description provided.

@fjchen7
Create type Address
641be19
@fjchen7
Implement method Decode of Address
d181da2
@fjchen7
Check encoding
23e859b
@fjchen7
Add test cases for function Decode
41574f3
@fjchen7
Add SerializeHashTypeByte
14bce52
@fjchen7
Implement method Encode of Address
cd76859
@fjchen7
Add test cases for method Encode
9c2c9e0
@fjchen7
Change type of receiver from pointer to type
2db0464
@fjchen7
Extract duplicate code in TestEncode
9f49379
@fjchen7
Add method DeserializeHashTypeByte
42b2159
@fjchen7
Improve test case about encoding and decoding script with hashType `D…
7fc0eab 
…ATA`
@fjchen7
Test invalid encode
83fec44
@fjchen7
Change type of Script to pointer in Address
808060d
@fjchen7
Add function GenerateScriptSecp256K1Blake160SignhashAll
c6551c7
@fjchen7
Replace address.Parse with address.Decode
8c72210
@fjchen7
Check address type in NewIdentityItemByAddress
36690bf
@fjchen7
Remove deprecated functions about address
e1d09a0
@fjchen7
Remove unused constant code hash
cb4683a
@fjchen7
Rename files
e080b86
@fjchen7
Polish error message
66116ba
@fjchen7
Cover full test cases for address
f9ab50c
@fjchen7
Add documentation comments
3af5055
@fjchen7
Add GenerateScriptSecp256K1Blake160SignhashAllByPublicKey
e347d2d
@fjchen7
Add method SignTransactionByPrivateKeys to TransactionSigner
f031367
@fjchen7 fjchen7 requested a review from quake July 14, 2022 14:53
quake
quake requested changes Jul 15, 2022
View reviewed changes
address/address.go Outdated Show resolved Hide resolved
types/serialize_types.go Show resolved Hide resolved
@fjchen7 fjchen7 requested a review from quake July 15, 2022 06:33
@fjchen7 fjchen7 merged commit 67962d5 into nervosnetwork:refactor Jul 15, 2022
@fjchen7 fjchen7 changed the title feat: refator address feat: refactor address Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjchen7 @quake