Refactored flexible memory implementation #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanson
changed the title
xxuejie
reviewed
Aug 28, 2023
xxuejie
approved these changes
Oct 25, 2023
mohanson
changed the title
XuJiandong
changed the title
XuJiandong
requested changes
Oct 31, 2023
| machine | ||
| } | ||
|
|
||
| pub fn set_max_cycles(&mut self, cycles: u64) { | ||
| self.max_cycles = cycles; | ||
| } | ||
| } | ||
|
|
||
| impl AsmCoreMachine { | ||
| pub fn cast_ptr_to_slice(&self, ptr: u64, offset: usize, size: usize) -> &[u8] { |
| } | ||
| } | ||
|
|
||
| pub fn cast_ptr_to_slice_mut(&self, ptr: u64, offset: usize, size: usize) -> &mut [u8] { |
XuJiandong
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dynamic memory implementation has several problems:
flagsandframesare always alloced according to the 4M memory size.This PR will make AsmCoreMachine accept memory ptr, flags ptr and frames ptr instead of memory u8 array, flags array and frames array.