Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tx_monitor): fix #3309, mismatch resolved_tx and completed_tx #3365

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix(tx_monitor): fix #3309, mismatch resolved_tx and completed_tx #3365

merged 1 commit into from
Apr 6, 2022

Conversation

chanhsu001
Copy link
Contributor

What problem does this PR solve?

fix #3309, cycles mismatched when monitor tx verified result.

What is changed and how it works?

mismatched between resolved(txs) and cache_entries(verified_result), because resolve(txs) includes cellbase_tx and cache_entries already exclude cellbase tx.

  • PR to update owner/repo:

Tests

  • Manual test (add detailed scripts or steps below)
    I will contact with Devops team member, help to verify it.

Release note

None: Exclude this PR from the release note.

@chanhsu001 chanhsu001 requested a review from a team as a code owner April 2, 2022 07:58
@chanhsu001 chanhsu001 requested review from quake and removed request for a team April 2, 2022 07:58
@quake
Copy link
Member

quake commented Apr 2, 2022

better to add the pr description mismatched between resolved(txs) and cache_entries(verified_result), because resolve(txs) includes cellbase_tx and cache_entries already exclude cellbase tx. to the code comment

@chanhsu001
Copy link
Contributor Author

better to add the pr description mismatched between resolved(txs) and cache_entries(verified_result), because resolve(txs) includes cellbase_tx and cache_entries already exclude cellbase tx. to the code comment

added comment in code, make it verbose, Thanks.

@chanhsu001 chanhsu001 merged commit f8cb6e3 into nervosnetwork:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants