Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Fix default ckb.toml's [notifier] to [notify] #4405

Merged
merged 5 commits into from
Apr 16, 2024
Merged

[Breaking Change] Fix default ckb.toml's [notifier] to [notify] #4405

merged 5 commits into from
Apr 16, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 9, 2024 •
edited
Loading

What problem does this PR solve?

The [notifier] should be [notify]

ckb/util/app-config/src/legacy/mod.rs

Lines 58 to 59 in 6ae6d06

#[serde(default)]
notify: crate::NotifyConfig,

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec marked this pull request as ready for review April 9, 2024 10:24
@eval-exec eval-exec requested a review from a team as a code owner April 9, 2024 10:24
@eval-exec eval-exec requested review from doitian and quake and removed request for a team April 9, 2024 10:24
@eval-exec eval-exec marked this pull request as draft April 9, 2024 10:32
@eval-exec eval-exec marked this pull request as ready for review April 9, 2024 10:56
@eval-exec eval-exec changed the title Change default ckb.toml [notifier] to [notify] [Breaking Change] Fix default ckb.toml's [notifier] to [notify] Apr 9, 2024
@eval-exec eval-exec added the breaking change The feature breaks consensus, database, message schema or RPC interface. label Apr 9, 2024
@eval-exec
Copy link
Collaborator Author

eval-exec commented Apr 12, 2024 •
edited
Loading

TODO:

  • add a bats-cli test

@eval-exec eval-exec marked this pull request as draft April 15, 2024 01:49
@eval-exec eval-exec marked this pull request as ready for review April 15, 2024 02:32
@quake quake added this pull request to the merge queue Apr 16, 2024
Merged via the queue into nervosnetwork:develop with commit c19bcf5 Apr 16, 2024
32 checks passed
@eval-exec eval-exec deleted the exec/fix-config-notify branch April 16, 2024 12:31
@doitian doitian mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
breaking change The feature breaks consensus, database, message schema or RPC interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @quake