feat: add estimate_fee_rate rpc #4465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
zhangsoledad,
chenyukang and
eval-exec
and removed request for
a team
eval-exec
reviewed
May 20, 2024
|
|
||
| ###### Params | ||
|
|
||
| * `target_to_be_committed` - The target block number to be committed, minimum value is 3 and maximum value is 131. |
There was a problem hiding this comment.
The rpc parameter target_to_be_committed is limited to 3~131, because the minimum value of the proposal window is 2, which is equivalent to predicting the height of current_tip + 1 ~ 128.
128+2=130
eval-exec
approved these changes
May 20, 2024
chenyukang
reviewed
May 21, 2024
|
merged into #4477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resolve #3673
What is changed and how it works?
Since CKB transaction confirmation involves a two-step process: 1) propose and 2) commit, it is complex to predict the transaction fee accurately with the expectation that it will be included within a certain block height.
This PR relies on two assumptions and uses a simple strategy to estimate the transaction fee: 1) all transactions in the pool are waiting to be proposed, and 2) no new transactions will be added to the pool. In practice, this simple method should achieve good accuracy fee rate and running performance.
The rpc parameter
target_to_be_committedis limited to 3~131, because the minimum value of the proposal window is 2, which is equivalent to predicting the height of current_tip + 1 ~ 128.Check List
Tests
Release note